feat(desktop): import browser cookies into a profile by juliusmarminge · Pull Request #7255 · pingdotgg/t3code

juliusmarminge · 2026-08-16T20:42:59Z

Stacked on #7272 (shared-sqlite-client).

Imports cookies from Helium on macOS into a T3 Code browser profile. Saved passwords and browsing history remain out of scope.

The app requests the browser key through the in-process Keychain API, so consent belongs to T3 Code. Denial stops the import; there is no permission bypass. Source databases are opened read-only and snapshotted consistently with SQLite before extraction.

The wizard chooses a source and destination, prevents profile edits during an import, and reports imported/skipped counts and affected sites. Plaintext and encrypted cookie records are handled separately; domain-bound records are validated. Partitioned cookies are skipped when their partition semantics cannot be preserved by Electron.

Validation includes synthetic decryption records, plaintext and legacy records, domain-binding failures, partitioned-cookie rejection, WAL snapshot consistency, interrupted writes, and wizard state transitions, plus scoped typechecks/lint. Earlier Helium imports were verified in the desktop app; this audit did not request another live Keychain read.

Original implementation: Claude Code. Review fixes: GPT-5.6 Sol agents, coordinated through Codex.

Note

Add browser cookie import into desktop profiles via `BrowserImport` wizard

Adds a desktop BrowserImport service that discovers Chromium-based browser profiles, reads and decrypts cookies (macOS keychain + AES-128-CBC v10), and writes them into an Electron session partition with per-cookie skip accounting
Adds a BrowserImportWizard modal with quit, checking, configure, importing, done, and blocked screens, driven by browserImportWizard.logic.ts and contract schemas in browserImport.ts
Reworks IntegrationsSettings.tsx browser profile UI into a grouped list with per-row default/clear/remove actions and a combined add-profile/import menu; removes the standalone default-profile selector
Adds a serialized client-settings persistence queue in useSettings.ts so awaited updates resolve only after durable writes and concurrent optimistic patches are preserved
Behavioral Change: profile creation and mutation controls are disabled during an active import; the separate default-profile settings row is removed and default selection moves to profile row options; import reads a SQLite snapshot via VACUUM INTO rather than the live database file

^{Macroscope summarized b8e2cab.}

Note

High Risk
Reads and decrypts another browser's cookies via Keychain consent, writes into Electron session partitions, and touches path-validation and live-database locking—security- and data-sensitive despite extensive guards and tests.

Overview
Adds cookie import from installed Chromium-family browsers (initially Helium on macOS) into T3 Code browser profiles, so preview sessions can reuse existing logins without passwords or history.

The desktop app gains a BrowserImport service that discovers sources, blocks import while the source browser is running, validates profile paths, snapshots the SQLite cookie DB, decrypts via the in-process macOS Keychain (@napi-rs/keyring), and writes cookies into the same Electron partition the target profile uses. New IPC/preload APIs expose listBrowserImportSources and importBrowserCookies; contracts define sources, failure reasons, and result counts.

Integrations → Browser profiles is reworked: Add profile opens a menu for a blank profile or Import from a detected browser, with a BrowserImportWizard for source/target selection, quit-browser flow, and imported/skipped reporting. New profiles are persisted only after a successful import via persistClientSettingsUpdate (serialized client-settings writes). Default profile is set from the profile list menu instead of a separate setting row.

Desktop packaging stages @napi-rs/keyring native binaries alongside existing native-addon staging.

^{Reviewed by Cursor Bugbot for commit b8e2cab. Bugbot is set up for automated code reviews on this repo. Configure here.}

coderabbitai · 2026-08-16T20:43:08Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: daf12449-bccc-4c49-a6df-572e284b0f18

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp

Reviewed the new BrowserImport service, its Chromium cookie helper, and the IPC/layer wiring against the Effect service conventions.

Service shape, module layout (Context.Service tag + inline interface, make, layer), namespace imports, and layer composition in main.ts all look correct. The findings below are about the error model: the new failure type is unstructured (reason: Schema.String) and every construction discards the underlying cause, including one that erases a structured BrowserSession error.

^{Posted via Macroscope — Effect Service Conventions}

github-actions · 2026-08-16T20:46:52Z

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	—	13.4 KiB	—	15.1 KiB	✅
Codex	Thread snapshot wire	—	6.9 KiB	—	7.3 KiB	✅
Codex	Live turn WebSocket wire	—	6.6 KiB	—	7.8 KiB	✅
Codex	Live turn WebSocket decoded	—	57.0 KiB	—	66.4 KiB	✅
Codex	Live turn messages	—	10	—	21	✅
Claude	Total thread wire	—	13.5 KiB	—	15.1 KiB	✅
Claude	Thread snapshot wire	—	6.9 KiB	—	7.3 KiB	✅
Claude	Live turn WebSocket wire	—	6.6 KiB	—	7.8 KiB	✅
Claude	Live turn WebSocket decoded	—	57.8 KiB	—	66.4 KiB	✅
Claude	Live turn messages	—	10	—	21	✅

Baseline: unavailable · PR result: b8e2cab · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 109.4 KiB
Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp

UI Consistency

One finding in the changed browser-profiles UI (apps/web/src/components/settings/IntegrationsSettings.tsx).

The menu/primitive usage itself looks consistent with the shared system: Menu/MenuPopup/MenuItem/MenuSub from components/ui/menu, MenuTrigger render={<Button …/>} matching the existing pattern in PreviewMoreMenu/ProjectScriptsControl, existing size="icon-sm" / variant="ghost-muted" Button variants, min-w-* on popups honouring MenuPopup's width-defaulting contract, and the bordered list container matching the convention already used in ConnectionsSettings. aria-labels are preserved on both the rename input and the new row trigger.

The issue is a state-display regression introduced by removing the default-profile Select while filtering Incognito out of the new list: a stored default of incognito (which the removed Select allowed a user to pick) now leaves the section with no "Default" badge on any row.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-16T22:24:14Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a substantial desktop cookie-import workflow involving OS Keychain access, encrypted browser databases, profile partition writes, and native dependency packaging. It also adds file-level static-analysis suppressions, so the scope and sensitivity warrant human review.

^{You can add or adjust custom eligibility rules. Learn more.}

macroscopeapp

Reviewed the new BrowserImport service, its Sources/ChromiumCookies helpers, the IPC method, and the layer wiring against the Effect service conventions. The service module follows the canonical shape (errors → Context.Service with inline interface → make → layer), dependencies are acquired from the environment, and the failure translations now keep a real cause. One remaining gap on error context.

^{Posted via Macroscope — Effect Service Conventions}

macroscopeapp

UI Consistency — 1 finding

The two issues flagged on earlier commits are addressed: loadSources now clears sources before each refresh, and resolvedDefaultId resolves against the rendered rows.

One consistency gap remains: with BrowserDefaultProfileSetting removed and Incognito no longer rendered as a row, the section can badge Default on a profile that is not the effective default (see inline comment).

Minor (not blocking): lines 507–529 now carry three consecutive doc comments for a single component — the "Create, rename, and remove browser profiles" and "Per-profile cookie import" blocks are leftovers from the removed/renamed pieces and could be folded into one.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

Two findings in the reworked browser-profiles section. Both are about the settings UI now disagreeing with the runtime behaviour it configures, rather than styling.

^{Posted via Macroscope — UI Consistency}

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{Bugbot Autofix is ON, but a cloud agent failed to start.}

^{Reviewed by Cursor Bugbot for commit 4938f4c. Configure here.}

Two review findings: the import menu only hid uninstalled sources, so a platform that can never import from a browser (a macOS-only fork on Linux) still listed it and clicking led to a dead-end blocked screen — those are now left out too. And the "Default profile" search entry lost the word "browser" when its settings row went away, which broke the "default browser profile" query and read ambiguously beside its siblings; the search-only title says "Default browser profile" again. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 16, 2026

macroscopeapp Bot reviewed Aug 16, 2026

View reviewed changes

Comment thread apps/desktop/src/preview/BrowserImport/BrowserImport.ts Outdated

Comment thread apps/desktop/src/preview/BrowserImport/Sources.ts Outdated

macroscopeapp Bot reviewed Aug 16, 2026

View reviewed changes

Comment thread apps/web/src/components/settings/IntegrationsSettings.tsx Outdated

juliusmarminge mentioned this pull request Aug 16, 2026

feat(desktop): import from Chrome, Edge, Brave, Vivaldi, Opera, Arc and Firefox #7260

Open

juliusmarminge force-pushed the browser-profile-import branch from 757f025 to 5853095 Compare August 16, 2026 22:08

github-actions Bot added the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Aug 16, 2026

macroscopeapp Bot reviewed Aug 16, 2026

View reviewed changes

Comment thread apps/web/src/components/settings/IntegrationsSettings.tsx

juliusmarminge marked this pull request as ready for review August 16, 2026 22:18

cursor Bot reviewed Aug 16, 2026

View reviewed changes

Comment thread apps/desktop/src/preview/BrowserImport/BrowserImport.ts Outdated

Comment thread apps/desktop/src/preview/BrowserImport/ChromiumCookies.ts

juliusmarminge mentioned this pull request Aug 16, 2026

refactor(shared): move the node:sqlite Effect SQL client into shared #7272

Open

juliusmarminge force-pushed the browser-profile-import branch from 5853095 to 23b22b9 Compare August 16, 2026 22:53

juliusmarminge changed the base branch from browser-profiles to shared-sqlite-client August 16, 2026 22:54

macroscopeapp Bot reviewed Aug 16, 2026

View reviewed changes

Comment thread apps/desktop/src/preview/BrowserImport/ChromiumCookies.ts Outdated

macroscopeapp Bot reviewed Aug 16, 2026

View reviewed changes

Comment thread apps/web/src/components/settings/IntegrationsSettings.tsx Outdated

Comment thread apps/web/src/components/settings/IntegrationsSettings.tsx

macroscopeapp Bot reviewed Aug 16, 2026

View reviewed changes

Comment thread apps/desktop/src/preview/BrowserImport/ChromiumCookies.ts

macroscopeapp Bot reviewed Aug 16, 2026

View reviewed changes

Comment thread apps/web/src/components/settings/IntegrationsSettings.tsx

macroscopeapp Bot reviewed Aug 16, 2026

View reviewed changes

Comment thread apps/web/src/components/settings/IntegrationsSettings.tsx

Comment thread apps/web/src/components/settings/IntegrationsSettings.tsx Outdated

cursor Bot reviewed Aug 16, 2026

View reviewed changes

Comment thread apps/desktop/src/preview/BrowserImport/ChromiumCookies.ts Outdated

Comment thread apps/web/src/components/settings/IntegrationsSettings.tsx

juliusmarminge force-pushed the browser-profile-import branch from 57fccc1 to ea2efcb Compare August 16, 2026 23:21

cursor Bot reviewed Aug 16, 2026

View reviewed changes

Comment thread apps/web/src/components/settings/IntegrationsSettings.tsx Outdated

juliusmarminge force-pushed the browser-profile-import branch from 3264ff7 to 76fc9d2 Compare August 16, 2026 23:59

juliusmarminge added 24 commits September 1, 2026 16:33

fix(desktop): skip partitioned Chromium cookies

4e750d8

fix(desktop): target imports at profile partition

03265df

fix(desktop): follow tagged error catch convention

97a7443

fix(web): keep browser profile menus available

6835959

fix(web): preserve browser import source selection

b405932

fix(web): pin browser import environment

874b0ad

fix(web): clarify browser import destination copy

2e9db96

fix(desktop): ignore stale Chromium locks

21e79dd

fix(desktop): guard Chromium liveness errors

660d103

fix(desktop): decode Chromium text schema versions

17b44eb

fix(web): hide browser import close while writing

270501f

fix(web): explain unavailable profile cleanup

1c3aac8

fix(web): block imports without source profiles

bd2a6b3

fix(web): hydrate settings before profile imports

ad3182f

fix(web): explain unavailable browser imports

1d0ff8d

fix(desktop): normalize IPv6 cookie URLs

b8c8b3c

fix(web): await imported profile persistence

a668ef3

fix(web): revalidate browser import targets

66154ad

fix(web): explain removed import targets

1884a5e

fix(web): serialize client settings persistence

9284b4c

fix(web): show pointer on import choices

6363aef

fix(desktop): read browser lock hostname from service

f44458b

fix(web): clarify empty browser imports

8f02b0d

fix(web): normalize import destination labels

4938f4c

juliusmarminge force-pushed the browser-profile-import branch from 683ca1b to 4938f4c Compare September 1, 2026 23:35

github-actions Bot removed the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Sep 1, 2026

macroscopeapp Bot reviewed Sep 1, 2026

View reviewed changes

Comment thread apps/web/src/components/settings/settingsSearch.ts Outdated

cursor Bot reviewed Sep 1, 2026

View reviewed changes

Comment thread apps/web/src/components/settings/IntegrationsSettings.tsx

Uh oh!

Conversation

juliusmarminge commented Aug 16, 2026 • edited by macroscopeapp Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add browser cookie import into desktop profiles via BrowserImport wizard

Uh oh!

coderabbitai Bot commented Aug 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

macroscopeapp Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thread transfer impact

Uh oh!

macroscopeapp Bot left a comment

Choose a reason for hiding this comment

UI Consistency

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

macroscopeapp Bot commented Aug 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

Uh oh!

Uh oh!

Uh oh!

macroscopeapp Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

macroscopeapp Bot left a comment

Choose a reason for hiding this comment

UI Consistency — 1 finding

Uh oh!

Uh oh!

macroscopeapp Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

juliusmarminge commented Aug 16, 2026 •

edited by macroscopeapp Bot

Loading

Add browser cookie import into desktop profiles via `BrowserImport` wizard

coderabbitai Bot commented Aug 16, 2026 •

edited

Loading

github-actions Bot commented Aug 16, 2026 •

edited

Loading

macroscopeapp Bot commented Aug 16, 2026 •

edited

Loading